Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use current markup for header and footer #179

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Use current markup for header and footer #179

merged 2 commits into from
Apr 20, 2020

Conversation

36degrees
Copy link
Contributor

@36degrees 36degrees commented Apr 20, 2020 •
edited
Loading

Updates the tech docs to use the latest markup from the Design System

hannalaakso
hannalaakso approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🙌 (It would be good to update the PR description to say that "current" refers to current GOV.UK Design System header, for someone not familiar with the context)

@36degrees 36degrees merged commit ee57ac8 into master Apr 20, 2020
@36degrees 36degrees deleted the update-header-footer branch April 20, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannalaakso hannalaakso hannalaakso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@36degrees @hannalaakso